Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing NPM Vulnerabilities #72

Merged
merged 7 commits into from
Feb 5, 2019
Merged

Fixing NPM Vulnerabilities #72

merged 7 commits into from
Feb 5, 2019

Conversation

smusali
Copy link
Contributor

@smusali smusali commented Jan 30, 2019

Finally, could have fixed it:

  • removed lodash and replaced with built-in functionalities;
  • removed always-tail since no need for that;
  • updated grunt version from 0.4.5 to 1.0.3;
  • updated grunt-mocha-cli version from 2.0.0 to 4.0.0;
  • since grunt-mocha-cli is using mocha@4.0.0, I had to modify the test suites to support mocha@4.0.0 - Mocha had new and core changes in v3.0.0 and newer versions listed here and here - grunt-mocha-cli@2.0.0 is using mocha@2.0.0 and having high and critical vulnerabilities;
  • now, npm audit fix (after npm install and having package-lock.json) says there is no vulnerability at all.

Tested on Node v6.10.2 and NPM v6.4.1.

@smusali smusali self-assigned this Jan 30, 2019
@smusali smusali requested a review from leeliu January 30, 2019 01:48
@smusali smusali changed the title FIxing NPM Vulnerabilities Fixing NPM Vulnerabilities Jan 30, 2019
@leeliu leeliu merged commit a64298f into logdna:master Feb 5, 2019
@smusali smusali deleted the npmAuditFix branch February 13, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants