BREAKING CHANGE: feat(levels)!: Support custom log levels in LogDNA #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakedipity
reviewed
Sep 16, 2021
As Winston allows for the use of custom log levels, now so does LogDNA. Custom levels can be defined for both Winston and LogDNA such that those custom levels will show up on LogDNA's log viewer. BREAKING CHANGE: This removes the log level "translation" that used to be in place to convert Winston levels to ones that would be acceptable by LogDNA. Since LogDNA can now define custom levels as well, this translation is no longer needed, however it may break implementations that are relying on the translated levels. Fixes: #31
darinspivey
force-pushed
the
darinspivey/issue31
branch
from
23d7aa2
to
63d8a77
Compare
jakedipity
approved these changes
Sep 16, 2021
evanlucas
approved these changes
Sep 17, 2021
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(levels)!: Support custom log levels in LogDNA
As Winston allows for the use of custom log levels, now
so does LogDNA. Custom levels can be defined for both
Winston and LogDNA such that those custom levels will
show up on LogDNA's log viewer.
BREAKING CHANGE: This removes the log level "translation"
that used to be in place to convert Winston levels to ones
that would be acceptable by LogDNA. Since LogDNA can now
define custom levels as well, this translation is no longer
needed, however it may break implementations that are
relying on the translated levels.
Fixes: #31
chore(deps): eslint-config-logdna@5.1.0
chore(deps): semantic-release-config-logdna@1.3.0
chore(deps): semantic-release@17.4.7
chore(deps): eslint@7.32.0