Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maxEventListeners reached from reading file after backpressure #41

Closed
darinspivey opened this issue Feb 13, 2024 · 2 comments · Fixed by #42
Closed

maxEventListeners reached from reading file after backpressure #41

darinspivey opened this issue Feb 13, 2024 · 2 comments · Fixed by #42
Labels
released

Comments

@darinspivey
Copy link
Contributor

darinspivey commented Feb 13, 2024 •
edited
Loading

When backpressure is reached, the async iterator created for for await...of adds more event listeners onto the stream. The code should setMaxListeners(100) to allow some breathing room for such cases (and avoid pesky node warnings)
@darinspivey
Copy link
Contributor Author

Fixing this issue will also prompt an upgrade of the supported node versions, thus it will be a major

darinspivey added a commit that referenced this issue Feb 13, 2024
@darinspivey
fix!: Set max listeners to tolerate backpressure
0e69e94 
If a file isn't immediately put into flowing mode, then backpressure
could be invoked right away. Doing so can add many more event listeners
onto the stream as it uses the async iterator. This increases the max
listeners above the default for a little more tolerance before seeing
the nasty node warnings about event emitter leaks.

BREAKING CHANGE: `node 16` is becoming unsupported soon. Change the
supported versions to be >= `18`

Fixes: #41
@darinspivey darinspivey mentioned this issue Feb 13, 2024
Merged
darinspivey added a commit that referenced this issue Feb 13, 2024
@darinspivey
fix!: Set max listeners to tolerate backpressure
9946590 
If a file isn't immediately put into flowing mode, then backpressure
could be invoked right away. Doing so can add many more event listeners
onto the stream as it uses the async iterator. This increases the max
listeners above the default for a little more tolerance before seeing
the nasty node warnings about event emitter leaks.

BREAKING CHANGE: `node 16` is becoming unsupported soon. Change the
supported versions to be >= `18`

Fixes: #41
darinspivey added a commit that referenced this issue Feb 13, 2024
@darinspivey
fix!: Set max listeners to tolerate backpressure
2c3a669 
If a file isn't immediately put into flowing mode, then backpressure
could be invoked right away. Doing so can add many more event listeners
onto the stream as it uses the async iterator. This increases the max
listeners above the default for a little more tolerance before seeing
the nasty node warnings about event emitter leaks.

BREAKING CHANGE: `node 16` is becoming unsupported soon. Change the
supported versions to be >= `18`

Fixes: #41
@logdnabot
Copy link
Member

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix!: Set max listeners to tolerate backpressure logdna/tail-file-node
2 participants
@darinspivey @logdnabot