Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify license in package.json? #43

Closed
cakoose opened this issue Mar 13, 2024 · 2 comments · Fixed by #44
Closed

Specify license in package.json? #43

cakoose opened this issue Mar 13, 2024 · 2 comments · Fixed by #44
Labels
released

Comments

@cakoose
Copy link

cakoose commented Mar 13, 2024

There's a field in the package.json file that allows you to specify the project's license. There are tools that take advantage of this. For example, I use a tool like license-checker to help check that I'm not using a package that has an incompatible license.

When I ran that tool on my codebase, it was able to determine the license for most packages, but not able to do so for this package. This project's license is the MIT license, but the package.json currently has: "SEE LICENSE IN LICENSE":

tail-file-node/package.json

Line 75 in f87a8cc

"license": "SEE LICENSE IN LICENSE",

Would you be open to putting "MIT" in the package.json's "license" field?
@darinspivey
Copy link
Contributor

Yes, we can accommodate that.

darinspivey added a commit that referenced this issue Mar 14, 2024
@darinspivey
fix(pkg): Set license in package.json accurately
330fb14 
Certain tooling may try to take advantage of the `license` field in
`package.json`.  Since this is an MIT licensed product, reflect that in
the license field.

Fixes: #43
@darinspivey darinspivey mentioned this issue Mar 14, 2024
Merged
darinspivey added a commit that referenced this issue Mar 14, 2024
@darinspivey
fix(pkg): Set license in package.json accurately
52dd185 
Certain tooling may try to take advantage of the `license` field in
`package.json`.  Since this is an MIT licensed product, reflect that in
the license field.

Fixes: #43
@logdnabot
Copy link
Member

🎉 This issue has been resolved in version 4.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(pkg): Set license in package.json accurately logdna/tail-file-node
3 participants
@cakoose @darinspivey @logdnabot