Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async append blocking with timeout #565

Merged
merged 7 commits into from
Jul 14, 2021
Merged

Async append blocking with timeout #565

merged 7 commits into from
Jul 14, 2021

Commits on Jul 10, 2021

  1. First implementation of Async append blocking until an optional timeout 

    See logfellow#559
    @brenuart
    brenuart committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    d55ce29 View commit details
    Browse the repository at this point in the history

  2. Wait for the buffer to drain before calling Disruptor#shutdown 

    Calling Disruptor#shutdown(timeout) while the buffer is not empty causes the disruptor to wait in a busy-loop consommuing a lot of CPU. Instead, wait during the grace period before asking the disruptor to shutdown immediately.

Related issue: logfellow#566
    @brenuart
    brenuart committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    c3db6af View commit details
    Browse the repository at this point in the history

  3. Get rid of AsyncMode and rely solely on “appendTimeout” 

    Block/drop behaviour is entirely controlled by the value of the “appendTimeout” property:
- `-1` to disable timeout and wait until enough space becomes available
- `0` for no timeout at all and drop the event immediately when the buffer is full
- `> 0` to retry during the specified amount of time
    @brenuart
    brenuart committed Jul 10, 2021
    Configuration menu
    Copy the full SHA
    db89593 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2021

  1. Handle appender stopped after wake up + validate configuration parame… 

    …ters
    @brenuart
    brenuart committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    e958cfc View commit details
    Browse the repository at this point in the history

  2. Document the appendTimeout feature

    @brenuart
    brenuart committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    db41c40 View commit details
    Browse the repository at this point in the history

  3. Group information related to cleanly shutting down the appender insid… 

    …e the same section
    @brenuart
    brenuart committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    fa66d0b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into gh559-async-block

    @brenuart
    brenuart authored Jul 14, 2021
    Configuration menu
    Copy the full SHA
    38b0a87 View commit details
    Browse the repository at this point in the history