Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new JsonProviders for exception messages #743

Closed
wants to merge 2 commits into from
Closed

Add new JsonProviders for exception messages #743

wants to merge 2 commits into from

Conversation

twz123
Copy link
Contributor

@twz123 twz123 commented Jan 10, 2022

  • New providers throwableMessage and throwableRootCauseMessage
  • New cyclic reference safe algorithm to determine a throwable's root cause
  • Share that algorithm between throwableRootCauseClassName and throwableRootCauseMessage

@twz123
Add new JsonProviders for exception messages
0f34df8 
* New providers `throwableMessage` and `throwableRootCauseMessage`
* New cyclic reference safe algorithm to determine a throwable's root
  cause
* Share that algorithm between `throwableRootCauseClassName` and
  `throwableRootCauseMessage`
philsttr
philsttr reviewed Mar 12, 2022
View reviewed changes
Copy link
Collaborator

@philsttr philsttr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! This looks really good. Love the tests!

I just had a question about circular references.

And I'd love it if you could add some more javadocs for the new public classes/methods.

src/main/java/net/logstash/logback/composite/loggingevent/ThrowableSelectors.java Show resolved Hide resolved
@twz123
Copy link
Contributor Author

twz123 commented Mar 18, 2022

I've added a couple of javadocs, I hope it matches what you had in mind.

philsttr pushed a commit that referenced this pull request Apr 2, 2022
@twz123 @philsttr
Merge PR #743 Add new JsonProviders for exception messages
69f5ce8 
* New providers `throwableMessage` and `throwableRootCauseMessage`
* New cyclic reference safe algorithm to determine a throwable's root
  cause
* Share that algorithm between `throwableRootCauseClassName` and
  `throwableRootCauseMessage`
@philsttr
Copy link
Collaborator

philsttr commented Apr 2, 2022

Fixed missing javadoc param, and squash merged.

Thanks for the contribution!

@philsttr philsttr closed this Apr 2, 2022
@philsttr philsttr added this to the 7.1 milestone Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philsttr philsttr philsttr left review comments

Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.
2 participants
@twz123 @philsttr