-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow inline stacktrace generation #807
allow inline stacktrace generation #807
Conversation
I haven't add the time to fully review your PR yet... Sorry about that. |
src/main/java/net/logstash/logback/stacktrace/ShortenedThrowableConverter.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #807 +/- ##
============================================
- Coverage 70.87% 70.86% -0.01%
- Complexity 1250 1253 +3
============================================
Files 167 167
Lines 4796 4802 +6
Branches 497 498 +1
============================================
+ Hits 3399 3403 +4
- Misses 1151 1152 +1
- Partials 246 247 +1
Continue to review full report at Codecov.
|
Hi @MarneusCalgarXP, it would be nice if you could also add some information/documentation about this new feature in the relevant section of the README.md. |
src/main/java/net/logstash/logback/stacktrace/ShortenedThrowableConverter.java
Show resolved
Hide resolved
done |
I made some additional cosmetic changes to your PR. It has been merged manually, reason why I'm simply closing the PR. |
thank you for merging it ;-) |
allow inline stacktrace generation, adding an
inline
option tonet.logstash.logback.stacktrace.ShortenedThrowableConverter
ie:
result in a single line :
2022-05-10 11:06:46,859+0200 ERROR [ main] com.example.demo.DemoApplication [ ] - failure || mdc=[] java.lang.IllegalAccessException: a\n at com.example.demo.DemoApplication.lambda$run$0(DemoApplication.java:40)\n at o.springframework.boot.SpringApplication.callRunner(SpringApplication.java:777)\n ... 3 common frames omitted\nWrapped by: java.lang.IllegalStateException: Failed to execute CommandLineRunner\n at o.springframework.boot.SpringApplication.callRunner(SpringApplication.java:780)\n at o.springframework.boot.SpringApplication.callRunners(SpringApplication.java:761)\n at o.springfr...\n
(useful for rsyslog or fluentd when you don't want to use
json
format)