Java API Fixes for statistics (#105)

logicalclocks · Sep 28, 2020 · 7f938f1 · 7f938f1
1 parent 9d7ec52
commit 7f938f1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/java/src/main/java/com/logicalclocks/hsfs/FeatureGroup.java b/java/src/main/java/com/logicalclocks/hsfs/FeatureGroup.java
@@ -118,7 +118,7 @@ public FeatureGroup(FeatureStore featureStore, @NonNull String name, Integer ver
     this.onlineEnabled = onlineEnabled;
     this.defaultStorage = defaultStorage != null ? defaultStorage : Storage.OFFLINE;
     this.features = features;
-    this.statisticsEnabled = statisticsEnabled;
+    this.statisticsEnabled = statisticsEnabled != null ? statisticsEnabled : true;
     this.histograms = histograms;
     this.correlations = correlations;
     this.statisticColumns = statisticColumns;

diff --git a/java/src/main/java/com/logicalclocks/hsfs/TrainingDataset.java b/java/src/main/java/com/logicalclocks/hsfs/TrainingDataset.java
@@ -120,7 +120,7 @@ public TrainingDataset(@NonNull String name, Integer version, String description
     this.splits = splits;
     this.seed = seed;
     this.featureStore = featureStore;
-    this.statisticsEnabled = statisticsEnabled;
+    this.statisticsEnabled = statisticsEnabled != null ? statisticsEnabled : true;
     this.histograms = histograms;
     this.correlations = correlations;
     this.statisticColumns = statisticColumns;
@@ -307,6 +307,7 @@ public Statistics computeStatistics() throws FeatureStoreException, IOException
    * @throws FeatureStoreException
    * @throws IOException
    */
+  @JsonIgnore
   public Statistics getStatistics() throws FeatureStoreException, IOException {
     return statisticsEngine.getLast(this);
   }
@@ -319,6 +320,7 @@ public Statistics getStatistics() throws FeatureStoreException, IOException {
    * @throws FeatureStoreException
    * @throws IOException
    */
+  @JsonIgnore
   public Statistics getStatistics(String commitTime) throws FeatureStoreException, IOException {
     return statisticsEngine.get(this, commitTime);
   }