Skip to content

Commit

Permalink
Revert "[HOPSWORKS-3201][append] set training dataset start end time (#…
Browse files Browse the repository at this point in the history
…679)"

This reverts commit 8d37269.
  • Loading branch information
SirOibaf committed Jun 16, 2022
1 parent 6ccde4f commit df4f81d
Showing 1 changed file with 4 additions and 20 deletions.
24 changes: 4 additions & 20 deletions python/hsfs/core/feature_view_engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -227,34 +227,18 @@ def _set_event_time(self, feature_view_obj, training_dataset_obj):
split.name == TrainingDatasetSplit.TRAIN
and not split.start_time
):
df = (
feature_view_obj.query._left_feature_group.select_all().read()
if df is None
else df
)
df = feature_view_obj.query.read() if df is None else df
split.start_time = self._get_start_time(df, event_time)
if split.name == TrainingDatasetSplit.TEST and not split.end_time:
df = (
feature_view_obj.query._left_feature_group.select_all().read()
if df is None
else df
)
df = feature_view_obj.query.read() if df is None else df
split.end_time = self._get_end_time(df, event_time)
else:
if not training_dataset_obj.event_start_time:
df = (
feature_view_obj.query._left_feature_group.select_all().read()
if df is None
else df
)
df = feature_view_obj.query.read() if df is None else df
training_dataset_obj.event_start_time = self._get_start_time(
df, event_time
)
df = (
feature_view_obj.query._left_feature_group.select_all().read()
if df is None
else df
)
df = feature_view_obj.query.read() if df is None else df
training_dataset_obj.event_end_time = self._get_end_time(
df, event_time
)
Expand Down

0 comments on commit df4f81d

Please sign in to comment.