Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove read() method from spark engine #7

Closed
moritzmeister opened this issue Feb 3, 2020 · 1 comment · Fixed by #9
Closed

Remove read() method from spark engine #7

moritzmeister opened this issue Feb 3, 2020 · 1 comment · Fixed by #9
Assignees
@SirOibaf

Comments

@moritzmeister
Copy link
Contributor

moritzmeister commented Feb 3, 2020 •
edited
Loading

Remove the redundant read() method from spark engine. .sql() is enough.
@moritzmeister
Copy link
Contributor Author

Also I think you are logging the query twice. Once in the query and once in spark engine.

@SirOibaf SirOibaf mentioned this issue Feb 4, 2020
Merged
moritzmeister pushed a commit that referenced this issue Feb 5, 2020
@SirOibaf
#7 remove read method from spark engine, #8 replace head with show() (#9
430061f 
)
tdoehmen referenced this issue in tdoehmen/feature-store-api Sep 22, 2022
@tdoehmen
allow timestamp=None for feature group as of (#7)
b8d34fc
tdoehmen added a commit that referenced this issue Sep 22, 2022
@davitbzh @bubriks @tdoehmen
[HOPSWORKS-3326] Support datetime in hsfs python API (#783)
ac21e4d 
* remove unused import

* init

* black has been run

* add datetime object

* add datetime object

* check timestamp length

* address comments

* allow timestamp=None for feature group as of (#7)

* fix tests

* remove redundant timestamp conversions

* address comments

* updated docstrings (#8)

Co-authored-by: Ralf <bubriks@gmail.com>
Co-authored-by: Till Döhmen <till.doehmen@web.de>
kennethmhc pushed a commit to kennethmhc/feature-store-api that referenced this issue Sep 23, 2022
@davitbzh @kennethmhc
[HOPSWORKS-3326] Support datetime in hsfs python API (logicalclocks#783)
54a0d4c 
* remove unused import

* init

* black has been run

* add datetime object

* add datetime object

* check timestamp length

* address comments

* allow timestamp=None for feature group as of (logicalclocks#7)

* fix tests

* remove redundant timestamp conversions

* address comments

* updated docstrings (logicalclocks#8)

Co-authored-by: Ralf <bubriks@gmail.com>
Co-authored-by: Till Döhmen <till.doehmen@web.de>
(cherry picked from commit ac21e4d)

# Conflicts:
#	python/hsfs/constructor/query.py
#	python/hsfs/core/feature_view_engine.py
#	python/hsfs/engine/python.py
#	python/hsfs/feature_group.py
#	python/hsfs/training_dataset.py
#	python/hsfs/util.py
#	python/tests/engine/test_python.py
#	python/tests/engine/test_spark.py
SirOibaf pushed a commit that referenced this issue Sep 26, 2022
@davitbzh @SirOibaf
[HOPSWORKS-3326] Support datetime in hsfs python API (#783)
0b1c163 
* remove unused import

* init

* black has been run

* add datetime object

* add datetime object

* check timestamp length

* address comments

* allow timestamp=None for feature group as of (#7)

* fix tests

* remove redundant timestamp conversions

* address comments

* updated docstrings (#8)

Co-authored-by: Ralf <bubriks@gmail.com>
Co-authored-by: Till Döhmen <till.doehmen@web.de>
(cherry picked from commit ac21e4d)

# Conflicts:
#	python/hsfs/constructor/query.py
#	python/hsfs/core/feature_view_engine.py
#	python/hsfs/engine/python.py
#	python/hsfs/feature_group.py
#	python/hsfs/training_dataset.py
#	python/hsfs/util.py
#	python/tests/engine/test_python.py
#	python/tests/engine/test_spark.py
kennethmhc pushed a commit to kennethmhc/feature-store-api that referenced this issue Nov 16, 2022
@davitbzh @bubriks
@tdoehmen @kennethmhc
[HOPSWORKS-3326] Support datetime in hsfs python API (logicalclocks#783)
7dc7116 
* remove unused import

* init

* black has been run

* add datetime object

* add datetime object

* check timestamp length

* address comments

* allow timestamp=None for feature group as of (logicalclocks#7)

* fix tests

* remove redundant timestamp conversions

* address comments

* updated docstrings (logicalclocks#8)

Co-authored-by: Ralf <bubriks@gmail.com>
Co-authored-by: Till Döhmen <till.doehmen@web.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SirOibaf SirOibaf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#7] remove read method from spark engine, [#8] replace head with show()
2 participants
@SirOibaf @moritzmeister