Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature group api and hive and spark engine #10

Merged
merged 11 commits into from
Feb 19, 2020
Merged

Add feature group api and hive and spark engine #10

merged 11 commits into from
Feb 19, 2020

Conversation

moritzmeister
Copy link
Contributor

No description provided.

@moritzmeister moritzmeister added python WIP This issue or pull request is a work in progress labels Feb 4, 2020
@moritzmeister
Copy link
Contributor Author

moritzmeister commented Feb 5, 2020 •
edited
Loading

Should be ready for review. Some open points:

  1. Getting multiple feature stores -> create multiple engines or set feature-store name every time. Hive connection needs feature store name to connect to right database. Needs to be tested if default here works when the sql has the full table qualifier with database name, e.g. [feature_store].[feature_group]_[version].
  2. REMOVING connect() method will be done in separate PR
  3. Executing Plain SQL query against feature store, will be added separately
  4. Factor out Project API from Client, as it's done in the Java API, to be consistent

@moritzmeister moritzmeister removed the WIP This issue or pull request is a work in progress label Feb 5, 2020
@moritzmeister
Copy link
Contributor Author

moritzmeister commented Feb 5, 2020 •
edited
Loading

Closes #8

@moritzmeister moritzmeister requested review from SirOibaf and removed request for SirOibaf February 7, 2020 15:52
@moritzmeister moritzmeister mentioned this pull request Feb 18, 2020
Merged
@moritzmeister
Copy link
Contributor Author

closes #16 now

SirOibaf
SirOibaf reviewed Feb 19, 2020
View reviewed changes
python/hopsworks/engine/__init__.py Outdated

def get_instance():
global _engine
return _engine
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add a check if the engine has been closed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added check

@moritzmeister moritzmeister merged commit 4d8647c into logicalclocks:master Feb 19, 2020
@moritzmeister moritzmeister deleted the feature-group branch February 19, 2020 15:56
This was referenced Feb 19, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirOibaf SirOibaf SirOibaf left review comments

Assignees
No one assigned
Labels
python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moritzmeister @SirOibaf