Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOPSWORKS-2084] Remove default_storage option from feature groups #118

Merged
merged 2 commits into from
Nov 3, 2020

Conversation

moritzmeister
Copy link
Contributor

No description provided.

@moritzmeister
Copy link
Contributor Author

@davitbzh can you please review this, I rebased on your Hudi changes, but I am not entirely sure in which cases e.g. online/offline feature group what the arguments related to hudi should be.

https://logicalclocks.atlassian.net/browse/HOPSWORKS-2084
here's the description of the desired behaviour

Copy link
Contributor

@davitbzh davitbzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I don't see anything that can brake HUDI PR

@SirOibaf SirOibaf merged commit 7169a09 into logicalclocks:master Nov 3, 2020
@moritzmeister moritzmeister deleted the HOPSWORKS-2084 branch November 5, 2020 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants