[FSTORE-1247] Raise DataValidationException on validation failure of a dataframe if the validation ingestion policy is set to strict #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…estion policy set to strict
SirOibaf
requested changes
Feb 24, 2024
SirOibaf
approved these changes
Feb 27, 2024
vatj
added a commit
to vatj/feature-store-api
that referenced
this pull request
Feb 28, 2024
…a dataframe if the validation ingestion policy is set to strict (logicalclocks#1226) * Add DataValidationException class * Raise DataValidationException on validation failure if validation ignestion policy set to strict * Fix associated unit test * Append to insert documentation * Raise exception also when inserting only in the online Feature Store for External FG * Add documentation to insert for External FG * Refactor get_feature_group_url and improve DataValidationException message * Remove pytest bigquery.json --------- Co-authored-by: Fabio Buso <buso.fabio@gmail.com>
Merged
3 tasks
SirOibaf
added a commit
that referenced
this pull request
Feb 28, 2024
…a dataframe if the validation ingestion policy is set to strict (#1226) * Add DataValidationException class * Raise DataValidationException on validation failure if validation ignestion policy set to strict * Fix associated unit test * Append to insert documentation * Raise exception also when inserting only in the online Feature Store for External FG * Add documentation to insert for External FG * Refactor get_feature_group_url and improve DataValidationException message * Remove pytest bigquery.json --------- Co-authored-by: Fabio Buso <buso.fabio@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added for both regular and external feature group. Added docs for external feature group insert method.
Note that insert method of external feature group needs to be "fixed", as it is confusing. There is no materialization job or need to wait for example. To be addressed in separate PR
JIRA Issue: -
Priority for Review: -
Related PRs: -
How Has This Been Tested?
Checklist For The Assigned Reviewer: