Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOPSWORKS-2091] Label/Prediction feature metadata for training datasets #126

Merged
merged 2 commits into from
Nov 6, 2020
Merged

[HOPSWORKS-2091] Label/Prediction feature metadata for training datasets #126

merged 2 commits into from
Nov 6, 2020

Conversation

moritzmeister
Copy link
Contributor

No description provided.

@moritzmeister moritzmeister added enhancement New feature or request python labels Oct 29, 2020
davitbzh
davitbzh reviewed Oct 29, 2020
View reviewed changes
Copy link
Contributor

@davitbzh davitbzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think I need to update TFDataEngine according this PR. There label is required to provide. If its already set here then we should not ask user to set label there as well. Will do it after this is merged.

@moritzmeister
Copy link
Contributor Author

closes #21

@SirOibaf SirOibaf merged commit 4753612 into logicalclocks:master Nov 6, 2020
@moritzmeister moritzmeister deleted the HOPSWORKS-2091 branch November 12, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davitbzh davitbzh davitbzh left review comments

@SirOibaf SirOibaf SirOibaf approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moritzmeister @SirOibaf @davitbzh