[HOPSWORKS-1374] Append: get commit details in correct order and make upsert default op for fg.insert #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davitbzh
force-pushed
the
make_upsert_op_default
branch
from
38288cf to
08e36be
Compare
davitbzh
force-pushed
the
make_upsert_op_default
branch
from
e30131a to
8b48f4b
Compare
SirOibaf
requested changes
Nov 8, 2020
Comment on lines
374
to
376
| public Map<String, Map<String,String>> commitDetails() throws IOException, FeatureStoreException { | ||
| return featureGroupEngine.commitDetails(this, null); | ||
| } |
There was a problem hiding this comment.
Invert the order of these 2 functions so that they appear in the documentation from generic to specific
| @@ -168,7 +170,7 @@ private FeatureGroupCommit getLastCommitMetadata(SparkSession sparkSession, Stri | |||
| } | |||
|
|
|||
| // table name | |||
| String tableName = utils.getTableName(featureGroup); | |||
| String tableName = featureGroup.getName() + "_" + featureGroup.getVersion(); | |||
There was a problem hiding this comment.
Use this method instead:
| throws IOException, FeatureStoreException { | ||
| return featureGroupApi.commitDetails(featureGroup, limit); | ||
| List<FeatureGroupCommit> featureGroupCommits = featureGroupApi.commitDetails(featureGroup, limit); |
There was a problem hiding this comment.
If there are no commits, this is going to be null and the next part of the code will trigger a NullPointerException. Check for it.
python/hsfs/feature_group_commit.py
Outdated
| @@ -38,6 +42,8 @@ def __init__( | |||
| @classmethod | |||
| def from_response_json(cls, json_dict): | |||
| json_decamelized = humps.decamelize(json_dict) | |||
| if len(json_decamelized["items"]) >= 1: | |||
There was a problem hiding this comment.
there should be a count field returned by the API that lets you know how many items there are in the list. Check if we set the count field in the CommitDTO on the Hopsworks side.
added 2 commits
November 9, 2020 11:10
SirOibaf
approved these changes
Nov 9, 2020
davitbzh
pushed a commit
to davitbzh/feature-store-api
that referenced
this pull request
Nov 9, 2020
…and make upsert default op for fg.insert (logicalclocks#132)" This reverts commit 77d103d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.