Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOPSWORKS-2122] Backend not handling null TimeTravelFormat sent by client #133

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

moritzmeister
Copy link
Contributor

No description provided.

Copy link
Contributor

@davitbzh davitbzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the beginning idea was to have HUDI as default format. However, I get the point that it's the good idea to keep None for now until it becomes stable. Can you please add the same with Java client TimeTravelFormat.NONE ? So then it's the same in both.

@moritzmeister
Copy link
Contributor Author

@davitbzh this is not the actual default, the default gets set in the create_feature_group which is the only way to instantiate a feature group that is not coming from the backend. The default you were setting on the constructor was never going to be used. we should try to keep the defaults in the place where the object actually gets created. so in fact this change doesn't change behaviour. I just removed it to avoid confusion, as it never takes effect anyway.

@SirOibaf SirOibaf merged commit 23777d1 into logicalclocks:master Nov 6, 2020
@moritzmeister moritzmeister deleted the fix-python-hudi branch November 12, 2020 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants