Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On demand feature group over S3 buckets #185

Merged
merged 37 commits into from
Jan 7, 2021
Merged

On demand feature group over S3 buckets #185

merged 37 commits into from
Jan 7, 2021

Conversation

SirOibaf
Copy link
Contributor

@SirOibaf SirOibaf commented Dec 6, 2020

No description provided.

@SirOibaf
Copy link
Contributor Author

SirOibaf commented Dec 7, 2020

@moritzmeister - Please have a look at this PR - I still have to test computing statistics over a on-demand feature group.

@SirOibaf SirOibaf added the python label Dec 7, 2020
moritzmeister
moritzmeister reviewed Dec 7, 2020
View reviewed changes
Copy link
Contributor

@moritzmeister moritzmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments

python/hsfs/core/storage_connector_api.py Outdated Show resolved Hide resolved
python/hsfs/storage_connector.py Outdated Show resolved Hide resolved
python/hsfs/engine/spark.py Outdated Show resolved Hide resolved
@SirOibaf SirOibaf added the java label Jan 3, 2021
moritzmeister
moritzmeister suggested changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@moritzmeister moritzmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove that one line in the hopsworks client

@SirOibaf
Copy link
Contributor Author

SirOibaf commented Jan 4, 2021

please remove that one line in the hopsworks client

done

moritzmeister
moritzmeister approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@moritzmeister moritzmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SirOibaf SirOibaf merged commit ce659ad into logicalclocks:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moritzmeister moritzmeister moritzmeister approved these changes

Assignees
No one assigned
Labels
java python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SirOibaf @moritzmeister