Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dangerous query default #224

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Remove dangerous query default #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/hsfs/constructor/query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def __init__(
feature_store_id=None,
left_feature_group_start_time=None,
left_feature_group_end_time=None,
joins=[],
joins=None,
filter=None,
):
self._feature_store_name = feature_store_name
Expand All @@ -41,7 +41,7 @@ def __init__(
self._left_features = util.parse_features(left_features)
self._left_feature_group_start_time = left_feature_group_start_time
self._left_feature_group_end_time = left_feature_group_end_time
self._joins = joins
self._joins = joins or []
self._filter = filter
self._query_constructor_api = query_constructor_api.QueryConstructorApi()
self._storage_connector_api = storage_connector_api.StorageConnectorApi(
Expand Down
3 changes: 2 additions & 1 deletion python/hsfs/statistics_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ def __init__(
# use setters for input validation
self.correlations = correlations
self.histograms = histograms
self._columns = columns
# overwrite default with new empty [] but keep the empty list default for documentation
self._columns = columns or []

@classmethod
def from_response_json(cls, json_dict):
Expand Down