Version default to 1 for get methods and increment for create #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirOibaf
reviewed
Jul 3, 2020
SirOibaf
requested changes
Jul 3, 2020
Comment on lines
68
to
78
| public FeatureGroup getFeatureGroup(String name, Integer version) | ||
| throws FeatureStoreException, IOException { | ||
| if (Strings.isNullOrEmpty(name) || version == null) { | ||
| throw new FeatureStoreException("Both name and version are required"); | ||
| if (Strings.isNullOrEmpty(name)) { | ||
| throw new FeatureStoreException("Name is required"); | ||
| } | ||
| if (version == null) { | ||
| LOGGER.info("VersionWarning: No version provided for getting feature group `" + name + "`, defaulting to `" + | ||
| DEFAULT_VERSION + "`."); | ||
| } | ||
| return featureGroupApi.get(this, name, version); | ||
| } |
There was a problem hiding this comment.
The JVM way of achieve this is to have another method called getFeatureGroup(String name) which the only thing that does is to call getFeatureGroup(name, DEFAULT_VERSION)
There was a problem hiding this comment.
good catch, actually it wasn't setting the version to 1, so it was wrong. changed it, pls check if it's better now.
The backend isn't handling null versions for getting entities, but maybe it should?
Comment on lines
109
to
115
| if (Strings.isNullOrEmpty(name)) { | ||
| throw new FeatureStoreException("Name is required"); | ||
| } | ||
| if (version == null) { | ||
| LOGGER.info("VersionWarning: No version provided for getting training dataset `" + name + "`, defaulting to `" + | ||
| DEFAULT_VERSION + "`."); | ||
| } |
java/src/main/java/com/logicalclocks/hsfs/engine/TrainingDatasetEngine.java
Outdated
Show resolved
Hide resolved
java/src/main/java/com/logicalclocks/hsfs/engine/FeatureGroupEngine.java
Outdated
Show resolved
Hide resolved
SirOibaf
approved these changes
Jul 7, 2020
|
Closes #26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.