Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pydoop should handle hopsfs:// scheme #79

Merged
merged 5 commits into from
Aug 18, 2020
Merged

Pydoop should handle hopsfs:// scheme #79

merged 5 commits into from
Aug 18, 2020

Conversation

SirOibaf
Copy link
Contributor

Closes #78

@moritzmeister - if you have a better place to locate this piece of code, let me know

@SirOibaf SirOibaf requested a review from moritzmeister August 16, 2020 22:34
moritzmeister
moritzmeister reviewed Aug 17, 2020
View reviewed changes
Copy link
Contributor

@moritzmeister moritzmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The location of the class if fine, but I think we should move the hdfs.path._HdfsPathSplitter = _HopsFSPathSplitter line to the init of the engine package to be only executed when the spark engine is initialized, e.g. in this if-clause

feature-store-api/python/hsfs/engine/__init__.py

Line 26 in eb13122

_engine = spark.Engine()

python/hsfs/engine/spark.py Outdated Show resolved Hide resolved
python/hsfs/engine/spark.py Outdated Show resolved Hide resolved
python/hsfs/engine/spark.py Outdated Show resolved Hide resolved
@moritzmeister moritzmeister merged commit fdd69ed into logicalclocks:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moritzmeister moritzmeister moritzmeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pydoop should handle hopsfs:// scheme
2 participants
@SirOibaf @moritzmeister