[FSTORE-332] implement method for get_or_create_feature_view #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennethmhc
requested changes
Oct 4, 2022
java/src/main/java/com/logicalclocks/hsfs/metadata/FeatureViewApi.java
Outdated
Show resolved
Hide resolved
Co-authored-by: kennethmhc <kennethmhc@users.noreply.github.com>
Co-authored-by: kennethmhc <kennethmhc@users.noreply.github.com>
kennethmhc
requested changes
Oct 12, 2022
java/src/main/java/com/logicalclocks/hsfs/engine/FeatureViewEngine.java
Outdated
Show resolved
Hide resolved
kennethmhc
reviewed
Oct 14, 2022
| FeatureView featureView = null; | ||
| try { | ||
| featureView = get(featureStore, name, version); | ||
| } catch (IOException | FeatureStoreException e) { | ||
| if (e.getMessage().contains("Error: 404") && e.getMessage().contains("\"errorCode\":270181")) { | ||
| featureView = new FeatureView(name, version, query, description, featureStore, labels); | ||
| featureView = new FeatureView.FeatureViewBuilder(featureStore) | ||
| .name(name) |
There was a problem hiding this comment.
description is missing.
There was a problem hiding this comment.
ahh, thanks. good catch
davitbzh
added a commit
to davitbzh/feature-store-api
that referenced
this pull request
Oct 20, 2022
* [FSTORE-11] Add mkdocs macros dependency for docs (logicalclocks#800) * [HOPSWORKS-3296] Remove update of storage connector (logicalclocks#801) * [FSTORE-329] CommitDTO type field is not returned anymore after Payar… (logicalclocks#805) * [FSTORE-8] add query default argument in snowflake (logicalclocks#790) * [FSTORE-8][append] Add unit test (logicalclocks#808) * [FSTORE-33] Improve HSFS parameter description (logicalclocks#806) * [FSTORE-331] BigQuery connector doesn't work if the application is ex… (logicalclocks#809) * [FSTORE-331] BigQuery connector doesn't work if the application is executed on multiple nodes * Change the BigQuery configuration so that it uses the credential field (base64 encoding of the content of the credential file) instead of providing the path in the credentialFile property. * For Java, updated the tests to use JUnit5 to allow for the @tmpdir annotation * Check if options is null before checking if it's empty * [FSTORE-8][append] Java fix for snowflake connector (logicalclocks#810) * [FSTORE-345] Update documentation to reflect supported methods in hsfs engines (logicalclocks#814) * [HOPSWORKS-3345] Improve event time error message (logicalclocks#785) * improve error message * [FSTORE-348] Refactor Tutorials documentation page (logicalclocks#817) * fix style (logicalclocks#820) * [FSTORE-358] Add icon to external links in documentation navigation (logicalclocks#822) * [FSTORE-311] Improved timestamp with timezone handling (logicalclocks#821) * add timezone normalization to python engine * set spark session timezone to utc * stylecheck * set spark timezone in java client * style * remove spark proerty validation because its internally set as session property * [FSTORE-342] Add java tests to github pipeline (logicalclocks#819) * [FSTORE-342] Add java tests to github pipeline * Fix Java build * Add m2 caching * Remove failure ignore flag * [FSTORE-346] Handle as_of in feature view (logicalclocks#816) * handle as_of in feature view * fix style * add unit test * fix style * fix tests * fix style * fix style * refactor is_time_travel * address comments * fix style * [FSTORE-331][Append] Fix Storage Connector Tests on windows (logicalclocks#827) * [FSTORE-383] Feature View method documentation (logicalclocks#831) * [FSTORE-311][Append] Timezone-aware Timestamp conversion for PySpark client (logicalclocks#826) * fixed timezones for pyspark clients in different timezone * spark session timezone to utc * [FSTORE-359] Rename Transformation Function Output Types and Fix Timezone-related issues (logicalclocks#829) * remove unused import * spark types for tf * spark types for tf * tmp * merge rebase with upstream/master * [HOPSWORKS-3342][Append] unit tests (#9) * added unit tests for transformation functions * fixed stylecheck * fixed a small thing in docs * infer_python_type * fix tests * fix tests * fix checks * removed legacy types cast from test * add convert_column method, fix style * updated builtin transformation functions * style (cherry picked from commit 6ad26c4cb72cfd286dbb3c7049cd72f0aed3ab78) * made transformation functions timezone-safe (cherry picked from commit 176c2da134517648d568f69784b1e13c56c580f1) * style * removed deprecated np types * tests tf function returning none * style * fixed tests * style Co-authored-by: davitbzh <davit.bzhalava@gmail.com> * [HOPSWORKS-3326][Append] Timezone-independent conversion of Hudi Timestamps and Timezone-Sensitive GH-Actions (logicalclocks#828) * made conversion from utc explicit * windows and timezone action * rename action * change runner to windows * removed python variants from tz-local actions * added java tz local action * small rename * added tests * remove unused variable * set correct timezone in java tests * [FSTORE-332] implement method for get_or_create_feature_view (logicalclocks#813) * get_or_create_feature_view * uppercased Y * updated comments * format * added some basic tests Co-authored-by: Moritz Meister <8422705+moritzmeister@users.noreply.github.com> Co-authored-by: Fabio Buso <buso.fabio@gmail.com> Co-authored-by: Dhananjay Mukhedkar <55157590+DhananjayMukhedkar@users.noreply.github.com> Co-authored-by: kennethmhc <kennethmhc@users.noreply.github.com> Co-authored-by: davitbzh <davit.bzhalava@gmail.com> Co-authored-by: davitbzh <44586065+davitbzh@users.noreply.github.com>
kennethmhc
pushed a commit
to kennethmhc/feature-store-api
that referenced
this pull request
Nov 16, 2022
…clocks#813) * get_or_create_feature_view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds/fixes/changes...
JIRA Issue: -
Priority for Review: -
Related PRs: -
How Has This Been Tested?
Checklist For The Assigned Reviewer: