Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOPSWORKS-1982] Deequ statistics for Feature Groups/Training Datasets #96

Merged
merged 10 commits into from
Sep 25, 2020
Prev Previous commit
Next Next commit
remove setting statsenabled and columns after api call
moritzmeister committed Sep 1, 2020
commit 9776866675fa9bfc1f3e9689bc29be2b1ab0417f
Original file line number Diff line number Diff line change
@@ -97,10 +97,8 @@ public void saveFeatureGroup(FeatureGroup featureGroup, Dataset<Row> dataset,
// Update the original object - Hopsworks returns the incremented version
featureGroup.setVersion(apiFG.getVersion());
featureGroup.setId(apiFG.getId());
featureGroup.setStatisticsEnabled(apiFG.getStatisticsEnabled());
featureGroup.setCorrelations(apiFG.getCorrelations());
featureGroup.setHistograms(apiFG.getHistograms());
featureGroup.setStatisticColumns(apiFG.getStatisticColumns());

// Write the dataframe
saveDataframe(featureGroup, dataset, storage, SaveMode.Append, writeOptions);
@@ -181,9 +179,7 @@ public void deleteTag(FeatureGroup featureGroup, String name) throws FeatureStor

public void updateStatisticsConfig(FeatureGroup featureGroup) throws FeatureStoreException, IOException {
FeatureGroup apiFG = featureGroupApi.updateStatsConfig(featureGroup);
featureGroup.setStatisticsEnabled(apiFG.getStatisticsEnabled());
featureGroup.setCorrelations(apiFG.getCorrelations());
featureGroup.setHistograms(apiFG.getHistograms());
featureGroup.setStatisticColumns(apiFG.getStatisticColumns());
}
}