Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client fails to connect with guest LLO #269

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Client fails to connect with guest LLO #269

merged 1 commit into from
Jun 12, 2024

Conversation

gdethier
Copy link
Contributor

@gdethier gdethier commented Jun 12, 2024 •
edited
Loading

  • Client broke following data model change before migration (guest data are now a struct, not just an account ID).
  • Introduces missing unit tests.
  • Hotfix must be deployed ASAP, otherwise connection by any client fails as soon as a guest LLO is added to a network.

logion-network/logion-internal#1294

benoitdevos
benoitdevos approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@benoitdevos benoitdevos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gdethier gdethier merged commit 16bcba1 into prod Jun 12, 2024
1 check passed
@gdethier gdethier deleted the feature/fix-guests-support branch June 12, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitdevos benoitdevos benoitdevos approved these changes

Assignees

@gdethier gdethier

@benoitdevos benoitdevos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdethier @benoitdevos