Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for parachain / integration tests #5

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

benoitdevos
Copy link
Contributor

Migrate to parachain

  • Update client, client-node and node-api.
  • Use CollectionParams and ValidAccountId.

logion-network/logion-internal#1228

Add integration tests

  • 4 integrations tests are added, testing both CSV creation and import (validation is tested indirectly within import)
  • 2 new options are added, companion of --local: --creativeCommonsLoc and --logionClassificationLoc. These 2 options are reserved for testing locally (development/testing) and are just ignored when passing using --env.

Open issues

The SignAndSendStrategy had to be adapted to:

class IntegrationTestSignAndSendStrategy implements SignAndSendStrategy {

    canUnsub(result: ISubmittableResult): boolean {
        return result.isCompleted;
    }
}

Otherwise I get very very often NotFound or WrongCollectionLoc.

logion-network/logion-internal#1114

Copy link
Contributor

@gdethier gdethier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I would just check that 1) we can publish the images in the repo without any license and 2) we need to have 10 images published instead of 2-3.

@gdethier
Copy link
Contributor

gdethier commented Apr 25, 2024

...and also, I would love to learn a bit more about isCompleted.

@benoitdevos
Copy link
Contributor Author

Good job! I would just check that 1) we can publish the images in the repo without any license and 2) we need to have 10 images published instead of 2-3.

I have amended the commit with other images.

@benoitdevos
Copy link
Contributor Author

...and also, I would love to learn a bit more about isCompleted.

As discussed, I will investigate. But I can already confirm that integration tests are much more stable on my side - no failure yet after 4 runs - with this new setup.

@benoitdevos benoitdevos merged commit 47d8223 into main Apr 26, 2024
@benoitdevos benoitdevos deleted the feature/migrate-to-parachain branch April 26, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants