Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport wait_action node from nav2 #50

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

maksymdidukh
Copy link

@maksymdidukh maksymdidukh commented Oct 16, 2023

  • change duration type from int to double

  • change "1" to "1.0" as default wait_duration value

  • modify wait_action tests

  • fix

  • change int values to double in trees

  • add usage of Duration::from_seconds()

  • fix build failing issue

  • delete whitespace


Basic Info

Info Please fill out this column
Ticket(s) this addresses AMRNAV-5586
Primary OS tested on Ubuntu

Here is a link for a PR in ros-planning/nav2 ros-navigation#3871

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

…gation#3871)

* change duration tyype from int to double

* change "1" to "1.0" as default wait_duration value

* modify wait_action tests

* fix

* change int values to double in trees

* add usage of Duration::from_seconds()

* fix build failing issue

* delete whitespace
@maksymdidukh maksymdidukh merged commit b5f337f into iron Oct 16, 2023
@maksymdidukh maksymdidukh deleted the wait_action-backport branch October 16, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants