Add waku-chat example #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielSanchezQ
added
documentation
| while let Some(NetworkEvent::RawMessage(message)) = receiver.recv().await { | ||
| if let Ok(msg) = bincode::deserialize::<Message>(&message) { | ||
| if msg.user != user { | ||
| println!( |
There was a problem hiding this comment.
Maybe using tokio::io::stdout instead?
There was a problem hiding this comment.
Not sure the additional complexity is worth it since we can expect println! to be executed reasonably fast.
tokio::io:;stdout may also result in interleaved output.
Blocking is also the default behavior for tracing-subscriber for the reasons outlined here, so I think it makes sense to follow the same approach.
This is also an interesting read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an example use of the Overwatch framework to build a very simple chat application on top of Waku