-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Jenkins risczero setup #770
Conversation
cc: @yakimant, the issue with file permissions were related to cargo inside docker, adding you as this might be encountered in other rust project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks goot, but ci/Jenkinsfile.nightly.integration
changes are not clear.
@@ -18,10 +18,11 @@ pipeline { | |||
} | |||
|
|||
environment { | |||
/* Avoid cache poisoning by other jobs. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed go related variables as there's no longer go dependency.
1. What does this PR implement?
This PR updates the Docker images used in the Jenkins nightly integration tests. The changes include:
risczero
and related dependencies to the CI Docker image.cargo
dependencies as the Jenkins user in the CI environment.gcc
andg++
are installed along with other dependencies.These changes do not need to comply with the specification as they are strictly CI-related.
2. Does the code have enough context to be clearly understood?
Yes, the PR updates CI-related Dockerfiles and Jenkins configurations to use the latest dependencies and ensures that the build environment is correctly configured to run nightly integration tests. No functional changes to the product itself.
3. Who are the specification authors and who is accountable for this PR?
This PR is related to CI infrastructure and does not follow any product specification. The responsible parties for this PR are Nomos Engineering Team
4. Is the specification accurate and complete?
N/A
5. Does the implementation introduce changes in the specification?
N/A
Checklist