Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Jenkins risczero setup #770

Merged
merged 8 commits into from
Sep 26, 2024
Merged

CI: Jenkins risczero setup #770

merged 8 commits into from
Sep 26, 2024

Conversation

bacv
Copy link
Member

@bacv bacv commented Sep 26, 2024

1. What does this PR implement?

This PR updates the Docker images used in the Jenkins nightly integration tests. The changes include:

  • Switching the Rust base image from Debian 11 (bullseye) to Debian 12 (bookworm).
  • Adding risczero and related dependencies to the CI Docker image.
  • Installing cargo dependencies as the Jenkins user in the CI environment.
  • Updating all Dockerfiles to use Debian 12-based Rust images and ensuring gcc and g++ are installed along with other dependencies.

These changes do not need to comply with the specification as they are strictly CI-related.

2. Does the code have enough context to be clearly understood?

Yes, the PR updates CI-related Dockerfiles and Jenkins configurations to use the latest dependencies and ensures that the build environment is correctly configured to run nightly integration tests. No functional changes to the product itself.

3. Who are the specification authors and who is accountable for this PR?

This PR is related to CI infrastructure and does not follow any product specification. The responsible parties for this PR are Nomos Engineering Team

4. Is the specification accurate and complete?

N/A

5. Does the implementation introduce changes in the specification?

N/A

Checklist

  • 1. Description added.
  • 2. Context and links to Specification document(s) added (N/A for this PR).
  • 3. Main contact(s) (developers and CI maintainers) added.
  • 4. Implementation and Specification are 100% in sync including changes (N/A for this PR).
  • 5. Link PR to a specific milestone.

@bacv
Copy link
Member Author

bacv commented Sep 26, 2024

cc: @yakimant, the issue with file permissions were related to cargo inside docker, adding you as this might be encountered in other rust project.

@bacv bacv requested a review from yakimant September 26, 2024 13:48
Copy link
Member

@yakimant yakimant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goot, but ci/Jenkinsfile.nightly.integration changes are not clear.

@@ -18,10 +18,11 @@ pipeline {
}

environment {
/* Avoid cache poisoning by other jobs. */
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed go related variables as there's no longer go dependency.

@bacv bacv added this to the Iteration 7 milestone Sep 26, 2024
@bacv bacv merged commit a30a809 into master Sep 26, 2024
7 of 9 checks passed
@bacv bacv deleted the ci-jenkins-risczero branch September 26, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants