Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Coverage and PR workflows - no space left on device #798

Merged
merged 10 commits into from
Sep 30, 2024

Conversation

romanzac
Copy link
Contributor

@romanzac romanzac commented Sep 29, 2024

What does this PR implement?

  • Remove Android, Dotnet and Haskell support from Ubuntu Github runner to free up disk space. About 15 GB freed.
  • Add local actions/prune-vm
  • Update coverage and PR workflows

@romanzac romanzac requested a review from bacv September 29, 2024 06:35
@romanzac
Copy link
Contributor Author

Hi @bacv, we can use AdityaGarg8/remove-unwanted-software@v4.1 for PR workflow as well. Let me know, I can prepare the fix. It is a bit of a hack, but works instantly.

@romanzac romanzac marked this pull request as ready for review September 29, 2024 06:37
@bacv
Copy link
Member

bacv commented Sep 29, 2024

I would prefer not to use this, unless https://github.com/status-im/infra-ci/issues/152 takes more time to be closed.

In that case lets fork the action and pull changes from upstream only after reviewing them. Would DST team be willing to take maintenance of this action?

@apentori do you think we should wait for self hosted runners or add temporal solution?

@romanzac
Copy link
Contributor Author

I would prefer not to use this, unless status-im/infra-ci#152 takes more time to be closed.

In that case lets fork the action and pull changes from upstream only after reviewing them. Would DST team be willing to take maintenance of this action?

@apentori do you think we should wait for self hosted runners or add temporal solution?

Another alternative is to add rm command to our wfs? It is all what it does:
https://github.com/AdityaGarg8/remove-unwanted-software/blob/8831c82abf29b34eb2caac48d5f999ecfc0d8eef/action.yml#L95

@bacv
Copy link
Member

bacv commented Sep 29, 2024

Another alternative is to add rm command to our wfs? It is all what it does:

This could be added as self contained action in .github/actions/prune-vm or similar with dotnet and android deps removed. We would still rely on undocumented github stuff, but it would be slightly easier to track changes done to it if something stops working.

@romanzac romanzac changed the title fix: coverage workflow - no space left on device fix: coverage and PR workflows - no space left on device Sep 30, 2024
@romanzac romanzac changed the title fix: coverage and PR workflows - no space left on device fix: Coverage and PR workflows - no space left on device Sep 30, 2024
@romanzac
Copy link
Contributor Author

Another alternative is to add rm command to our wfs? It is all what it does:

This could be added as self contained action in .github/actions/prune-vm or similar with dotnet and android deps removed. We would still rely on undocumented github stuff, but it would be slightly easier to track changes done to it if something stops working.

Fixed both workflows since 4c44982

Copy link
Member

@bacv bacv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking into this and solving it!

Copy link
Collaborator

@danielSanchezQ danielSanchezQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hacking gh. Nice temporary fix.

@romanzac romanzac merged commit 2672b7b into master Sep 30, 2024
9 checks passed
@romanzac romanzac deleted the fix-coverage-workflow-disk-space branch September 30, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants