Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logseq-color-markup #622

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add logseq-color-markup #622

wants to merge 1 commit into from

Conversation

clemtibs
Copy link

@clemtibs clemtibs commented Feb 4, 2025

Submit a new Plugin to Marketplace

Plugin Github repo URL: https://github.com/clemtibs/logseq-color-markup

Github releases checklist

  • a legal package.json file.
  • a valid CI workflow build action for Github releases. (theme plugin for this).
  • a release which includes a release zip pkg from a successful build.
  • a clear README file, ideally with an image or gif showcase. (For more friendly to users, it is recommended to have English version description).
  • a license in the LICENSE file.

@xyhp915
Copy link
Collaborator

xyhp915 commented Feb 4, 2025

@clemtibs
Copy link
Author

clemtibs commented Feb 4, 2025

Thanks @xyhp915 for that, new to this process! Should be all fixed now.

Also, I needed to modify a couple things from the example you linked to prevent some warnings and errors:

This stage fails with Error 403: Resource not accessible by integration:

- name: Create Release
  uses: ncipollo/release-action@v1
  id: create_release
  env:
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
    VERSION: ${{ github.ref }}
  with:
    allowUpdates: true
    draft: false
    prerelease: false

Unless I add:

permissions:
  contents: write

just after:
runs-on: ubuntu-latest

Also, for the line:
echo "::set-output name=tag_name::$(git tag --sort version:refname | tail -n 1)"

set-output is depreciated. It's new format would be:
echo "{name}={tag_name::$(git tag --sort version:refname | tail -n 1)}" >> $GITHUB_OUTPUT

It's curious, the logs from your builds showed the warnings, but not the Error, and they're pretty similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants