Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise the default value of up to 512 MB #46

Conversation

andsel
Copy link
Contributor

@andsel andsel commented Sep 5, 2024

Release notes

Raise the default value of decode_size_limit_bytes up to 512 MB.

What does this PR do?

Updates the default value for setting decode_size_limit_bytes to 512MB from 20MB, and print a deprecation log to inform the user the default value will be lowered in future version.

Why is it important/What is the impact to the user?

Every parsing of incoming data should be limited, to avoid OOM. The original 20MB maybe is to low for some circumstances. To avoid generate noise to users that appropriately parses big json lines it's raised up to 512MB.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • [ ] I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@andsel andsel self-assigned this Sep 5, 2024
@andsel andsel added the bug label Sep 5, 2024
@andsel andsel marked this pull request as ready for review September 5, 2024 09:40
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a rewording suggestion, otherwise LGTM

Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
@andsel andsel merged commit d907249 into logstash-plugins:main Sep 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants