Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECS: add v8 support as alias for v1 #27

Merged
merged 2 commits into from
Nov 10, 2021
Merged

ECS: add v8 support as alias for v1 #27

merged 2 commits into from
Nov 10, 2021

Conversation

yaauie
Copy link
Contributor

@yaauie yaauie commented Nov 5, 2021

Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/

@yaauie yaauie requested a review from robbavey November 5, 2021 20:01
@yaauie
Copy link
Contributor Author

yaauie commented Nov 5, 2021 

logstash_1_fdb343482a24 |     `ecs_compatibility => v8`
logstash_1_fdb343482a24 |       Complex use
logstash_1_fdb343482a24 |         works as expected
logstash_1_fdb343482a24 |       Bug LOGSTASH-1225
logstash_1_fdb343482a24 |         clones events containing numbers
logstash_1_fdb343482a24 |       all defaults
logstash_1_fdb343482a24 |         should generate new clones + current event

-- https://app.travis-ci.com/github/logstash-plugins/logstash-filter-clone/jobs/546922677#L473-L479

robbavey
robbavey approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yaauie yaauie mentioned this pull request Nov 5, 2021
Merged
11 tasks
yaauie
yaauie commented Nov 5, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@yaauie yaauie merged commit 68b9a77 into logstash-plugins:main Nov 10, 2021
@yaauie yaauie mentioned this pull request Nov 10, 2021
Merged
@yaauie yaauie mentioned this pull request Nov 17, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbavey robbavey robbavey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yaauie @robbavey @roaksoax