Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: unified ECS target + validate field reference #86

Merged
merged 3 commits into from
Jun 8, 2021
Merged

Refactor: unified ECS target + validate field reference #86

merged 3 commits into from
Jun 8, 2021

Conversation

kares
Copy link
Contributor

@kares kares commented Jun 8, 2021 •
edited
Loading

a follow up on #85 to unify the info message being logged on missing target => ... in ECS mode

we'll also check the set target to have a valid field reference format ...

@kares kares requested a review from kaisecheng June 8, 2021 05:42
@kares kares changed the title Refactor: unified ECS target + validate field ref Refactor: unified ECS target + validate field reference Jun 8, 2021
kaisecheng
kaisecheng approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@kaisecheng kaisecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up for me. LGTM 🚥

@kares kares merged commit 30b2c23 into logstash-plugins:master Jun 8, 2021
@kares kares mentioned this pull request Jun 22, 2021
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaisecheng kaisecheng kaisecheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kares @kaisecheng @roaksoax