Changed cache behavior such that timeouts are cached along with failures #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any reason this hasn't been merged yet? |
|
@pemontto probably nobody has reviewed it |
|
Great, |
robcowart
approved these changes
Mar 9, 2018
andrewvc
added a commit
to andrewvc/logstash-filter-dns
that referenced
this pull request
Mar 9, 2018
Closed
andrewvc
added a commit
to andrewvc/logstash-filter-dns
that referenced
this pull request
Mar 9, 2018
|
Fix released in 3.0.8 Thanks for the contribution @mtopper ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had issues with the DNS plugin and resolving large amounts of domain names. I've found that timeouts are almost always a sign that the query is never going to succeeded from my configured DNS server, rather than an indication of a network issue.
Therefore, I modified my local copy of this plugin to treat timeouts as failures so that they can be cached.