Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent crash for non-string values #65

Merged

Conversation

yaauie
Copy link
Contributor

@yaauie yaauie commented Apr 6, 2022

When this plugin encounters a non-string (or non-single-element-array-of-strings) value in either resolve or reverse, log a warning instead of crashing.

Related: elastic/logstash#13975

@yaauie yaauie force-pushed the prevent-crash-for-non-string-values branch from d53c49f to 0d13390 Compare April 6, 2022 15:27
Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @yaauie taking care of this.
Posted a question on a unit test but it doesn't break functionality.

spec/filters/dns_spec.rb Outdated Show resolved Hide resolved
spec/filters/dns_spec.rb Outdated Show resolved Hide resolved
spec/filters/dns_spec.rb Outdated Show resolved Hide resolved
Co-authored-by: Mashhur <99575341+mashhurs@users.noreply.github.com>
@yaauie yaauie merged commit b617e81 into logstash-plugins:main Apr 20, 2022
@yaauie yaauie deleted the prevent-crash-for-non-string-values branch April 20, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants