Feat: added ssl_supported_protocols option #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andsel
reviewed
Mar 28, 2022
| s.add_runtime_dependency 'logstash-core-plugin-api', '>= 1.60', '<= 2.99' | ||
| s.add_runtime_dependency 'logstash-mixin-ecs_compatibility_support', '~>1.2' | ||
| s.add_runtime_dependency "logstash-mixin-http_client", ">= 7.1.0", '< 9.0.0' | ||
| s.add_runtime_dependency "logstash-mixin-http_client", ">= 7.2.0", '< 9.0.0' |
There was a problem hiding this comment.
The http_poller plugin doens't have the < 9.0.0 to you think we could remove it?
Author
There was a problem hiding this comment.
this is a common pattern ruby gems use to limit using a later version of the library,
you know there's a current 7.x versions that your code works with, 8.x will probably work as well but another major might be a bit too optimistic of an assumption - thus the upper bound limit.
andsel
approved these changes
Mar 28, 2022
andsel
left a comment
andsel
left a comment
There was a problem hiding this comment.
LGTM
Left just a note about the mixin upper bound limit, I was wonder if you think we could remove it, also http_poller input plugin doesn't have it.
However feel free to skip and merge this,
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actual option implementation provided by mixin logstash-plugins/logstash-mixin-http_client#40
NOTE: feature is tested in http output, test here do not include any ssl_ related testing.