Feat: check target is set in ECS mode #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaauie
requested changes
Jun 7, 2021
There was a problem hiding this comment.
A lot of really helpful clean-up along side this one 👍🏼
I've left a comment about the place for validation. I'd prefer we not need unit tests like these for every plugin that uses the ECS compatibility support's TargetCheck, especially because it is easy to create fragile specs that fail when changes are made upstream in Logstash core or in the ECS support gem. In a way we are "infecting" this gem with unit specs describing the inner workings of components that are outside of this plugin's control or concern.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if
target =>option is not present in ECS mode we log a warning (at info level).also includes some (debug) logging improvements that I managed to bump into ...