Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: check that target is set in ECS mode #96

Merged
merged 4 commits into from
Jul 14, 2021
Merged

Feat: check that target is set in ECS mode #96

merged 4 commits into from
Jul 14, 2021

Conversation

kares
Copy link
Contributor

@kares kares commented Jun 24, 2021 •
edited
Loading

and validate source / target as field references

  • we rely on the ecs mixin to do the target check (and log an info message)
  • there are existing specs checking for target working as expected

closing #90

@kares kares changed the title Feat: ECS compatibility - warn on missing target Feat: check that target is set in ECS mode Jun 24, 2021
@kares kares requested a review from elasticsearch-bot June 24, 2021 13:56
@kares kares requested review from yaauie and removed request for elasticsearch-bot June 30, 2021 05:50
@kares kares linked an issue Jun 30, 2021 that may be closed by this pull request
Implement ECS-Compatibility Mode #90
Closed
@kares kares mentioned this pull request Jun 30, 2021
Closed
11 tasks
@kares kares removed the request for review from yaauie July 8, 2021 16:03
karenzone
karenzone approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs build cleanly and LGTM

@andsel andsel self-requested a review July 9, 2021 07:30
andsel
andsel approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kares kares merged commit 371d9e1 into logstash-plugins:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karenzone karenzone karenzone approved these changes

@andsel andsel andsel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement ECS-Compatibility Mode
5 participants
@kares @andsel @karenzone @roaksoax @elasticsearch-bot