Feat: review and deprecate ssl protocol/cipher settings #450
Conversation
Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
| * Value type is <<string,string>> | ||
| * Supported values are: | ||
| ** `disabled`: unstructured connection metadata added at root level | ||
| ** `v1`: structured connection metadata added under ECS v1 compliant namespaces | ||
| ** `v8`: structured connection metadata added under ECS v8 compliant namespaces | ||
| * Default value depends on which version of Logstash is running: | ||
| ** When Logstash provides a `pipeline.ecs_compatibility` setting, its value is used as the default | ||
| ** Otherwise, the default value is `disabled`. |
There was a problem hiding this comment.
The asciidoc formatting is correct as it was. You don't even have to add the leading space to the first level bullets. Asciidoc automatically indents them for you.
The second level bullets are tagged ** and should be aligned with the left margin.
There was a problem hiding this comment.
yy it just read weird - the rest of the documented options had the whitespaces to aid while reading the source
There was a problem hiding this comment.
If you like the leading spaces before the first level bullets, I don't have a problem with that. They won't hurt anything, and as you point out, it's consistent with other options.
Asciidoc standard is to left align all bullets. I like following the standards because otherwise, people see things done differently and a new "pseudo standard" is born. Ultimately, you can decide.
docs/index.asciidoc
Outdated
| @@ -175,8 +175,9 @@ This plugin supports the following configuration options plus the <<plugins-{typ | |||
| | <<plugins-{type}s-{plugin}-ssl_key_passphrase>> |<<password,password>>|No | |||
| | <<plugins-{type}s-{plugin}-ssl_verify_mode>> |<<string,string>>, one of `["none", "peer", "force_peer"]`|No | |||
There was a problem hiding this comment.
While we're making things right, will you please move the ssl_verify_mode option to its proper place in alpha order--both here and in the description?
(a follow-up on #447)
cipher_suitesin favor ofssl_cipher_suites(with better validation of the supported cipher set)ssl_supported_protocolsas a replacement fortls_min_version/tls_max_version