Remove jar-dependencies dependency
#70
Merged
+10
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbavey
force-pushed
the
fix_jar_dependencies
branch
from
06f1a97 to
8038bd4
Compare
Add exclusion for 7.x
robbavey
force-pushed
the
fix_jar_dependencies
branch
from
596581f to
a5a4588
Compare
donoghuc
reviewed
Dec 4, 2024
| @@ -51,4 +51,4 @@ | |||
| require_jar('org.codehaus.mojo', 'animal-sniffer-annotations', '1.23') | |||
| require_jar('org.conscrypt', 'conscrypt-openjdk-uber', '2.5.2') | |||
| require_jar('org.threeten', 'threetenbp', '1.6.8') | |||
| require_jar('org.logstash.inputs', 'logstash-input-google_pubsub', '1.3.0') | |||
| require_jar('org.logstash.inputs', 'logstash-input-google_pubsub', '1.4.0') | |||
There was a problem hiding this comment.
Not following this change? Is this something that was missed previously?
There was a problem hiding this comment.
Yes, looks like it - this is automatically generated during the building of the jar. I assume whoever made the last update didn't build locally...
donoghuc
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.