Fix build script to run with Gradle 7 #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
andsel
force-pushed
the
fix/update_to_gradle7
branch
from
0a63505 to
16a9213
Compare
jsvd
approved these changes
Oct 27, 2021
build.gradle
Outdated
| classpath = sourceSets.main.runtimeClasspath | ||
| } | ||
|
|
||
| task generateGemJarRequiresFile { | ||
| configurations.implementation.canBeResolved = true |
There was a problem hiding this comment.
can you add a comment here on why this is needed?
There was a problem hiding this comment.
The problem is that without that the
configurations.implementation.allDependencies {....}can't see the resolved dependencies. According to the table (it's from Gradle's JavaLibraryPlugin, but the same applies to JavaPlugin) the implementation configuration doesn't resolve the dependencies.
Forcing that canBeResolved = true the dependencies get resolved and can be seen from the other inspection code segments.
There was a problem hiding this comment.
The best solution is to use runtimeClasspath in configurations.runtimeClasspath.allDependencies because it's already resolved and don't need the explicit resolution flag
andsel
force-pushed
the
fix/update_to_gradle7
branch
from
16a9213 to
8716136
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Update build infrastructure to Gradle 7.2
What does this PR do?
Update the Gradle wrapper used to version 7.2 and fixed
build.gradlescript.Why is it important/What is the impact to the user?
Developers can use JDK >= 17 to build the plugin
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration files (and/or docker env variables)I have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
How to test this PR locally
Run
./gradlew clean vendorRelated issues