Standardize SSL settings #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmocosta
force-pushed
the
standardize_ssl_settings
branch
from
5f895e5
to
277c66a
Compare
edmocosta
force-pushed
the
standardize_ssl_settings
branch
from
277c66a
to
55ea369
Compare
andsel
requested changes
Apr 4, 2023
src/main/java/org/logstash/plugins/inputs/http/util/SslSimpleBuilder.java
Show resolved
Hide resolved
src/test/java/org/logstash/plugins/inputs/http/util/SslSimpleBuilderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/logstash/plugins/inputs/http/util/SslSimpleBuilderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/logstash/plugins/inputs/http/util/SslSimpleBuilderTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does?
Added the following SSL settings
ssl_enabled: Enable/disable SSLssl_keystore_path: JKS keystore pathssl_keystore_password: JKS keystore passwordssl_client_authentication: Controls the server’s behavior in regard to requesting a certificate from client connectionsReviewed and deprecated the following SSL settings to comply with Logstash's naming convention:
sslin favor ofssl_enabledssl_verify_modein favor ofssl_client_authenticationkeystorein favor ofssl_keystore_pathkeystore_passwordin favor ofssl_keystore_passwordOther changes
SslSimpleBuildermethods.The behavior standardization across plugins, such as the accepted certificate formats, default values, etc will be tackled in future PRs.
Closes elastic/logstash#14928