-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: introduce a target check helper #6
Conversation
for re-use across plugins - unifying the message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, this certainly is on track.
Thinking about this purely from a usage perspective, it would be very nice if a developer could include a single module into their plugin and not have to do anything else (such as overriding Plugin#register
or modifying their existing override). That way we could validate the behaviour extensively here in this support gem, and consumers would simply need to validate the presence of this support gem in their plugin ancestors without also re-validating its behaviour at a unit level.
I've included some additional thoughts and pseudo-code in the diff.
lib/logstash/plugin_mixins/ecs_compatibility_support/target_check.rb
Outdated
Show resolved
Hide resolved
lib/logstash/plugin_mixins/ecs_compatibility_support/target_check.rb
Outdated
Show resolved
Hide resolved
lib/logstash/plugin_mixins/ecs_compatibility_support/target_check.rb
Outdated
Show resolved
Hide resolved
spec/logstash/plugin_mixins/ecs_compatibility_support/target_check_spec.rb
Outdated
Show resolved
Hide resolved
lib/logstash/plugin_mixins/ecs_compatibility_support/target_check.rb
Outdated
Show resolved
Hide resolved
…heck_spec.rb Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
regardless of ECS compatibility setting
lib/logstash/plugin_mixins/ecs_compatibility_support/target_check.rb
Outdated
Show resolved
Hide resolved
spec/logstash/plugin_mixins/ecs_compatibility_support/target_check_spec.rb
Outdated
Show resolved
Hide resolved
spec/logstash/plugin_mixins/ecs_compatibility_support/target_check_spec.rb
Outdated
Show resolved
Hide resolved
spec/logstash/plugin_mixins/ecs_compatibility_support/target_check_spec.rb
Outdated
Show resolved
Hide resolved
…heck_spec.rb Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
…heck_spec.rb Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
…heck_spec.rb Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
…eck.rb Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
…eck.rb Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
for re-use across plugins - unifying the message, usage: