Bring back the jar-dependencies #238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… time and pack them in the gem
Closed
3 tasks
|
@purbon this is awesome! Can you re-submit this as a PR against https://github.com/andrewvc/logstash-output-elasticsearch_java/tree/native_only ? We're moving the jars out of this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings jar-dependencies back, for now what this changes are doing is introducing a way to fetch jars at build time or during test execution, like this jars don't have to be living in the repo and things like upgrading versions gets simplified, plus no need to say reducing the size of the repo.
As jars are embedded also in the gem (at gem build time) this would mean offline plugin installation is still safe.
Looking forward to know your thoughts on it,
Relates to the changes/discussions proposed in elastic/logstash#3735