Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to work with influxdb 0.9 - try 2 #30

Merged
merged 5 commits into from
Feb 28, 2016

Conversation

timgriffiths
Copy link

So this captures everything that is in pull request #29 but also handle all the special "characters" the influxdb protocol wants your to treat in a special way, ie spaces and commas and equal signs.

contentfree and others added 5 commits October 23, 2015 16:43
It is not backwards compatible with 0.8.x

Changes include:

 * Updated the default for exclude_fields. Also got rspec running locally so I could actually test things
 * Fixing series name to 'measurement' from 'name' to match changes in Influxdb
 * Updated spec to reflect name-to-measurement change
 * Switching from ftw to manticore (following elasticsearch's lead). Also, added configuration for using some fields as Influxdb tags
 * Ensuring that extra tags / fields aren't created if their values are nil or empty
 * Move tags in the event to become Influxdb tags
 * Fixed for 0.9.0 Final
 * Ensure fields that are non-Numerics have quoted values
 * Each measurement should be on a separate line
     When separating measurements with a space, you will get a "400 Bad request". Measurements should be separated with a new line.
Fixing Unit tests to remove json check that is no longer valid
@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@contentfree
Copy link
Contributor

@timgriffiths, You've got to sign the CLA. (I think you said you had in #29, but it doesn't appear so here)

@timgriffiths
Copy link
Author

I really thought i did ... let me try again

Created: 2/1/16
By: CLA Committers (committers@elasticsearch.com)
Status: SIGNED
Transaction ID: CBJCHBCAABAAEUxKCiz3OGog52g8P8osKhzO52D6mVUs

@timgriffiths
Copy link
Author

Now doubly signed up

Created: 2/3/16
By: CLA Committers (committers@elasticsearch.com)
Status: SIGNED
Transaction ID: CBJCHBCAABAA6SjtIjPPAI_VAHThA0sINoFQ4njqOKNX

@suyograo
Copy link
Contributor

Tests pass

suyog@machine:~/ws/elastic/ls_plugins/logstash-output-influxdb (pr/30)$ bundle exec rspec
Using Accessor#strict_set for specs
Run options: exclude {:redis=>true, :socket=>true, :performance=>true, :couchdb=>true, :elasticsearch=>true, :elasticsearch_secure=>true, :export_cypher=>true, :integration=>true, :windows=>true}
.........

Finished in 1.62 seconds (files took 1.37 seconds to load)
9 examples, 0 failures

Randomized with seed 25191

Also confirmed CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants