-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to work with influxdb 0.9 - try 2 #30
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not backwards compatible with 0.8.x Changes include: * Updated the default for exclude_fields. Also got rspec running locally so I could actually test things * Fixing series name to 'measurement' from 'name' to match changes in Influxdb * Updated spec to reflect name-to-measurement change * Switching from ftw to manticore (following elasticsearch's lead). Also, added configuration for using some fields as Influxdb tags * Ensuring that extra tags / fields aren't created if their values are nil or empty * Move tags in the event to become Influxdb tags * Fixed for 0.9.0 Final * Ensure fields that are non-Numerics have quoted values * Each measurement should be on a separate line When separating measurements with a space, you will get a "400 Bad request". Measurements should be separated with a new line.
Fixing Unit tests to remove json check that is no longer valid
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
@timgriffiths, You've got to sign the CLA. (I think you said you had in #29, but it doesn't appear so here) |
I really thought i did ... let me try again
|
Now doubly signed up
|
Tests pass
Also confirmed CLA |
This was referenced Feb 28, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this captures everything that is in pull request #29 but also handle all the special "characters" the influxdb protocol wants your to treat in a special way, ie spaces and commas and equal signs.