Skip to content

Add support for arguments when declaring an exchange #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add support for arguments when declaring an exchange #54

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
937ed0e
Add support for arguments when declaring an exchange
Aug 5, 2016
f96a1dd
Merge remote-tracking branch 'upstream/master'
balooka Apr 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/logstash/outputs/rabbitmq.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,12 @@ class RabbitMQ < LogStash::Outputs::Base
# Should RabbitMQ persist messages to disk?
config :persistent, :validate => :boolean, :default => true

# Additional arguments for the exchange, for example could be the presence of an alternate exchange, ...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflict here -- the :validate => :array doesn't match up with your default value (a hash).

Also, the documentation for this setting isn't quite enough. Can you detail why a user would want to set this?

Is "arguments" the right word? It feels like it is not specific enough of a word.

config :arguments, :validate => :array, :default => {}

def register
connect!
@hare_info.exchange = declare_exchange!(@hare_info.channel, @exchange, @exchange_type, @durable)
@hare_info.exchange = declare_exchange!(@hare_info.channel, @exchange, @exchange_type, @durable, @arguments)
@codec.on_event(&method(:publish))
end

Expand Down