Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve HTTPD24_ERRORLOG parsing of proxy errors #327

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve HTTPD24_ERRORLOG parsing of proxy errors #327

wants to merge 1 commit into from

Conversation

smokris
Copy link

@smokris smokris commented Sep 15, 2024

Problem

Currently, HTTPD24_ERRORLOG fails to correctly parse this message:

[Fri Sep 13 20:16:16.614584 2024] [proxy_fcgi:error] [pid 74738:tid 74765] (70008)Partial results are valid but processing is incomplete: [client 203.0.113.1:0] AH01075: Error dispatching request to : (reading input brigade)

Analysis

  1. This clause appears to have a stray question mark:

    %{POSINT:[apache][error][proxy][error][code]?}

  2. This clause only allows ports 1 and greater (whereas the above log message indicates port 0):

    %{POSINT:[source][port]:int}

Proposed change

  1. Remove stray question mark
  2. Change POSINT to NONNEGINT

@smokris smokris force-pushed the patch-1 branch 4 times, most recently from def518b to 7cf194e Compare September 15, 2024 19:37
@smokris smokris marked this pull request as ready for review September 15, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@smokris