refactor(core): replace idTokenHint with clientId in sign-out url (…

…#57)
logto-io · Feb 28, 2023 · fdfee2c · fdfee2c
1 parent 7cbef08
commit fdfee2c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/client/sign_out.go b/client/sign_out.go
@@ -33,7 +33,7 @@ func (logtoClient *LogtoClient) SignOut(postLogoutRedirectUri string) (string, e
 
 	signOutUri, generateSignOutUriErr := core.GenerateSignOutUri(&core.SignOutUriGenerationOptions{
 		EndSessionEndpoint:    oidcConfig.EndSessionEndpoint,
-		IdToken:               idToken,
+		ClientId:              logtoClient.logtoConfig.AppId,
 		PostLogoutRedirectUri: postLogoutRedirectUri,
 	})
 

diff --git a/core/sign_out.go b/core/sign_out.go
@@ -4,7 +4,7 @@ import "net/url"
 
 type SignOutUriGenerationOptions struct {
 	EndSessionEndpoint    string
-	IdToken               string
+	ClientId              string
 	PostLogoutRedirectUri string
 }
 
@@ -16,7 +16,7 @@ func GenerateSignOutUri(option *SignOutUriGenerationOptions) (string, error) {
 
 	queries := uri.Query()
 
-	queries.Add("id_token_hint", option.IdToken)
+	queries.Add("client_id", option.ClientId)
 
 	if option.PostLogoutRedirectUri != "" {
 		queries.Add("post_logout_redirect_uri", option.PostLogoutRedirectUri)

diff --git a/core/sign_out_test.go b/core/sign_out_test.go
@@ -7,10 +7,10 @@ import (
 )
 
 func TestGenerateSignOutUriShouldGenerateCorrectUri(t *testing.T) {
-	testSignOutUri := "https://example.com/logout?id_token_hint=idToken&post_logout_redirect_uri=https://example.com/callback"
+	testSignOutUri := "https://example.com/logout?client_id=clientId&post_logout_redirect_uri=https://example.com/callback"
 	signOutUri, generateSignOutUriErr := GenerateSignOutUri(&SignOutUriGenerationOptions{
 		EndSessionEndpoint:    "https://example.com/logout",
-		IdToken:               "idToken",
+		ClientId:              "clientId",
 		PostLogoutRedirectUri: "https://example.com/callback",
 	})
 
@@ -19,11 +19,11 @@ func TestGenerateSignOutUriShouldGenerateCorrectUri(t *testing.T) {
 }
 
 func TestGenerateSignOutUriShouldGenerateCorrectUriWithoutPostLogoutRedirectUri(t *testing.T) {
-	testSignOutUri := "https://example.com/logout?id_token_hint=idToken"
+	testSignOutUri := "https://example.com/logout?client_id=clientId"
 
 	signOutUri, generateSignOutUriErr := GenerateSignOutUri(&SignOutUriGenerationOptions{
 		EndSessionEndpoint: "https://example.com/logout",
-		IdToken:            "idToken",
+		ClientId:           "clientId",
 	})
 
 	assert.Nil(t, generateSignOutUriErr)