Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove id token check for sign out #474

Merged
merged 1 commit into from
Apr 18, 2023
Merged

fix: remove id token check for sign out #474

merged 1 commit into from
Apr 18, 2023

Conversation

wangsijie
Copy link
Contributor

@wangsijie wangsijie commented Apr 18, 2023 •
edited
Loading

Summary

Remove "idToken" check for "sign out":

The problem is that, if the "idToken" is already expired, the sign out process will fail, then the user is not able to sign out and sign in again.

Testing

Local tested.

Checklist

  • .changeset
  • unit tests
  • integration tests
  • docs

OR

  • This PR is not applicable for the checklist

@linear
Copy link

linear bot commented Apr 18, 2023

LOG-5904 bug: Error: Not authenticated. when signing out.

logto-io/logto#3607

@wangsijie
Copy link
Contributor Author

This PR will fix #3607

@wangsijie wangsijie requested a review from a team April 18, 2023 05:53
@wangsijie wangsijie merged commit fc73418 into master Apr 18, 2023
@wangsijie wangsijie deleted the sijie-log-5904-fix-sign-out branch April 18, 2023 06:13
@wangsijie wangsijie mentioned this pull request Apr 18, 2023
Closed
@silverhand-bot silverhand-bot mentioned this pull request Apr 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charIeszhao charIeszhao charIeszhao approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangsijie @charIeszhao