Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(react-sample): remove unnecessary useEffect dependency #532

Merged
merged 1 commit into from
Jul 25, 2023
Merged

chore(react-sample): remove unnecessary useEffect dependency #532

merged 1 commit into from
Jul 25, 2023

Conversation

charIeszhao
Copy link
Member

Summary

Remove unnecessary dependency from useEffect, since setState methods aren't required to be listed as dependencies.

Testing

N/A

Checklist

  • This PR is not applicable for the checklist

@charIeszhao charIeszhao requested a review from a team July 25, 2023 03:54
@charIeszhao charIeszhao self-assigned this Jul 25, 2023
@charIeszhao charIeszhao enabled auto-merge (squash) July 25, 2023 03:54
@charIeszhao charIeszhao merged commit 54d7193 into master Jul 25, 2023
@charIeszhao charIeszhao deleted the charles-remove-unnecessary-dependency branch July 25, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangsijie wangsijie wangsijie approved these changes

Assignees

@charIeszhao charIeszhao

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charIeszhao @wangsijie