Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: capacitor sdk #535

Merged
merged 3 commits into from
Aug 4, 2023
Merged

feat: capacitor sdk #535

merged 3 commits into from
Aug 4, 2023

Conversation

gao-sun
Copy link
Member

@gao-sun gao-sun commented Aug 3, 2023 •
edited
Loading

Summary

add capacitor sdk for dev convenience.

Testing

tested locally with iOS simulator, sign-in/out/storage

Checklist

@gao-sun gao-sun requested a review from a team August 3, 2023 16:29
@gao-sun gao-sun marked this pull request as ready for review August 3, 2023 16:30
simeng-li
simeng-li approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@simeng-li simeng-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from gao-add-comment-annotations to master August 4, 2023 09:30
@gao-sun gao-sun merged commit eb94b36 into master Aug 4, 2023
20 checks passed
@gao-sun gao-sun deleted the gao-capacitor-sdk branch August 4, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangsijie wangsijie wangsijie approved these changes

@simeng-li simeng-li simeng-li approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gao-sun @wangsijie @simeng-li